The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 31, 2026 1:09am

PR Summary

High Risk
Closes a workflow-authenticated SSRF path on the hosted service where Connect serverUrl could reach localhost/internal networks; behavior change is intentional and scoped by deployment mode.

Overview
Tightens SSRF protection for user-supplied 1Password Connect serverUrl values by splitting policy on isHosted.

On hosted, validateConnectServerUrl now rejects all private and reserved IPs (loopback, RFC1918, metadata, etc.) via isPrivateOrReservedIP, including after DNS resolution, while still returning the resolved IP for DNS pinning. On self-hosted, private/loopback Connect URLs remain allowed; only link-local (e.g. cloud metadata) stays blocked.

Logic is centralized in assertConnectIpAllowed; the validator is exported and covered by new Vitest cases for hosted vs self-hosted, literals, DNS, and resolution failures.

^{Reviewed by Cursor Bugbot for commit 243a06e. Configure here.}

Greptile Summary

This PR strengthens the SSRF protection for 1Password Connect-mode routes by gating the IP validation policy on deployment type. The refactoring extracts a new assertConnectIpAllowed helper and correctly exports validateConnectServerUrl for direct testing without networking mocks.

• Hosted deployments now block all private/reserved IPs (loopback, RFC1918, link-local) via the existing isPrivateOrReservedIP utility, preventing tenants from reaching the platform's internal network.
• Self-hosted deployments retain the original behaviour — only link-local (cloud-metadata) addresses are blocked, since Connect servers legitimately reside on private RFC1918 ranges controlled by the operator.
• Policy enforcement covers both IP literals and DNS-resolved hostnames (preserving TOCTOU/rebinding protection), with 15 new unit tests covering all key combinations.

Confidence Score: 5/5

Safe to merge. The change is narrowly scoped to the 1Password Connect URL validator, the logic correctly branches on isHosted, and all IP edge cases are handled by the well-tested isPrivateOrReservedIP utility.

The refactoring is clean and well-tested. All IP edge cases (loopback, RFC1918, link-local, IPv4-mapped IPv6) are covered, and the old DNS catch-block re-throw hack has been correctly eliminated.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[validateConnectServerUrl] --> B{hostname is IP literal?}
    B -- Yes --> C[assertConnectIpAllowed\nip = literal]
    B -- No --> D[dns.lookup hostname]
    D -- error --> E[throw: hostname could not be resolved]
    D -- success --> F[assertConnectIpAllowed\nip = resolved address]
    C --> G{isHosted?}
    F --> G
    G -- true --> H{isPrivateOrReservedIP?}
    H -- true --> I[throw: private or reserved IP address]
    H -- false --> J[return IP for DNS pinning]
    G -- false --> K{range === linkLocal?}
    K -- true --> L[throw: link-local address]
    K -- false --> J

_{Reviews (2): Last reviewed commit: "test(security): use real isPrivateOrRese..." | Re-trigger Greptile}

@greptile

@cursor review